[PATCH] D41640: [ELF] - Do not ignore discarding of .rela.plt/.rela.dyn

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 8 13:07:44 PST 2018


ruiu added inline comments.


================
Comment at: ELF/LinkerScript.cpp:293
       // which are common because they are in the default bfd script.
-      if (Sec->Type == SHT_REL || Sec->Type == SHT_RELA)
+      if (!isa<SyntheticSection>(Sec) &&
+          (Sec->Type == SHT_REL || Sec->Type == SHT_RELA))
----------------
Obviously this needs comment because without it it is very hard to figure out what this `isa` for.


https://reviews.llvm.org/D41640





More information about the llvm-commits mailing list