[PATCH] D41827: [DEBUG] Initial adaptation of NVPTX target for debug info emission.

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 8 11:30:51 PST 2018


aprantl added inline comments.


================
Comment at: lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp:272
+  MCSymbol *LineTableStartSym;
+  if (Asm->getObjFileLowering().getTargetTriple().isNVPTX()) {
+    LineTableStartSym = TLOF.getDwarfLineSection()->getBeginSymbol();
----------------
We usually don't "embrace" single lines.


================
Comment at: lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp:272
+  MCSymbol *LineTableStartSym;
+  if (Asm->getObjFileLowering().getTargetTriple().isNVPTX()) {
+    LineTableStartSym = TLOF.getDwarfLineSection()->getBeginSymbol();
----------------
aprantl wrote:
> We usually don't "embrace" single lines.
I find it odd to query for a specific backend. Could we query for a feature in the backend instead?


https://reviews.llvm.org/D41827





More information about the llvm-commits mailing list