[PATCH] D32498: [CodeView] omit forward references for unnamed structs and unions

[Brock Wyma via Phabricator via llvm-commits]

bwyma updated this revision to Diff 128941.
bwyma added a comment.

I made the changes you requested.  Specifically:

- I check for an empty identifier in addition to an empty name on the composite type.
- I updated the code to call report_fatal_error when an unexpected cycle occurs in the type graph.
- I added a lit test containing a cycle in the type graph to make sure the error is caught.


https://reviews.llvm.org/D32498

Files:
  lib/CodeGen/AsmPrinter/CodeViewDebug.cpp
  test/DebugInfo/COFF/bitfields.ll
  test/DebugInfo/COFF/types-recursive-unnamed.ll
  test/DebugInfo/COFF/unnamed.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D32498.128941.patch
Type: text/x-patch
Size: 19708 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180108/6968716c/attachment.bin>