[PATCH] D41505: [DAG] Teach findBaseOffset to interpret indexes of indexed memory operations

Nirav Dave via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 8 08:40:49 PST 2018


niravd added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGAddressAnalysis.cpp:135
     }
+    // If we get here break out of the loop.
     break;
----------------
RKSimon wrote:
> Maybe add a LLVM_FALLTHROUGH and default case here?
We'd still need to have a trailing break after the switch (or a do-loop-again varaible) to drop out of the while loop because of the other 2 cases. 


https://reviews.llvm.org/D41505





More information about the llvm-commits mailing list