[PATCH] D41802: Allow users of the GCOV API to extend the FileInfo class to implement custom output formats

Marco Castelluccio via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jan 6 07:24:38 PST 2018


marco-c created this revision.
marco-c added reviewers: bogner, davide, scott.smith.

The GCOV API can be used to parse gcda/gcno files, but in order to implement custom output formats, users need to reimplement everything.
If the FileInfo members were protected instead of private, they'd be able to reuse the code.


Repository:
  rL LLVM

https://reviews.llvm.org/D41802

Files:
  include/llvm/ProfileData/GCOV.h


Index: include/llvm/ProfileData/GCOV.h
===================================================================
--- include/llvm/ProfileData/GCOV.h
+++ include/llvm/ProfileData/GCOV.h
@@ -428,7 +428,7 @@
   void print(raw_ostream &OS, StringRef MainFilename, StringRef GCNOFile,
              StringRef GCDAFile);
 
-private:
+protected:
   std::string getCoveragePath(StringRef Filename, StringRef MainFilename);
   std::unique_ptr<raw_ostream> openCoveragePath(StringRef CoveragePath);
   void printFunctionSummary(raw_ostream &OS, const FunctionVector &Funcs) const;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D41802.128846.patch
Type: text/x-patch
Size: 565 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180106/729664d6/attachment.bin>


More information about the llvm-commits mailing list