[PATCH] D41741: LowerTypeTests: Add limited support for aliases

Vlad Tsyrklevich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 5 15:47:09 PST 2018


vlad.tsyrklevich added inline comments.


================
Comment at: lib/Transforms/IPO/LowerTypeTests.cpp:1711
+        ExportedFunctions.erase(AliasName);
+        M.getFunction(AliasName)->removeFromParent();
+
----------------
pcc wrote:
> Similarly to my comment above, I think this will need to be a RAUW at the point where the alias is created in case the function declaration has any uses in the merged module.
I don't think it's possible for there to be any uses here since this function declaration is created in the code directly above and can not yet have any uses and none should be generated below (maybe I'm missing something about how such a use would be generated?)


Repository:
  rL LLVM

https://reviews.llvm.org/D41741





More information about the llvm-commits mailing list