[PATCH] D41737: [PowerPC] Try to move the stack pointer update instruction later in the prologue and earlier in the epilogue

Sean Fertile via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 4 19:52:58 PST 2018


sfertile added inline comments.


================
Comment at: lib/Target/PowerPC/PPCFrameLowering.cpp:827
+  // Check if we can move the stack update instruction (stdu) down the prologue
+  //  past the callee saves. Hopefully this wil avoid the situation where the
+  //  saves are waiting for the update on the store with update to complete.
----------------
wil -> will


================
Comment at: lib/Target/PowerPC/PPCFrameLowering.cpp:832
+  if (FrameSize && !FI->hasFastCall() && !FI->usesPICBase() && !HasFP &&
+      !HasBP && isInt<16>(FrameSize)) {
+    const std::vector< CalleeSavedInfo > & info = MFI.getCalleeSavedInfo();
----------------
Can we use `!isLargeFrame` here instead of `isInt<16>(FrameSize) `?


https://reviews.llvm.org/D41737





More information about the llvm-commits mailing list