[PATCH] D41727: [libcxx] Disable tautological-type-limit-compare warning

Brian Cain via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 4 08:54:48 PST 2018


bcain created this revision.
bcain added a reviewer: mclow.lists.
Herald added a reviewer: EricWF.

Clang change to "cripple" the warning (https://reviews.llvm.org/rC321691) was not effective for libcxx because we opt-in to Wextra

But since the warning is partitioned now, we could opt-out of this specific one?


Repository:
  rL LLVM

https://reviews.llvm.org/D41727

Files:
  libcxx/utils/libcxx/test/config.py


Index: libcxx/utils/libcxx/test/config.py
===================================================================
--- libcxx/utils/libcxx/test/config.py
+++ libcxx/utils/libcxx/test/config.py
@@ -900,6 +900,10 @@
             '-D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER',
             '-Wall', '-Wextra', '-Werror'
         ]
+
+        if self.cxx.hasWarningFlag('-Wno-tautological-type-limit-compare'):
+            self.cxx.warning_flags += ['-Wno-tautological-type-limit-compare',]
+
         if self.cxx.hasWarningFlag('-Wuser-defined-warnings'):
             self.cxx.warning_flags += ['-Wuser-defined-warnings']
             self.config.available_features.add('diagnose-if-support')


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D41727.128615.patch
Type: text/x-patch
Size: 681 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180104/efb261b6/attachment.bin>


More information about the llvm-commits mailing list