[PATCH] D41684: [llvm-objcopy] Add --localize-hidden option

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: test/tools/llvm-objcopy/localize-hidden.test:47
+  Global:
+    - Name:     defaultGlobal
+      Type:     STT_FUNC
----------------
Could we have a separate symbol for hidden Globals, please. Since that's going to be a relatively common case, I think it deserves explicit testing.


================
Comment at: tools/llvm-objcopy/Object.cpp:191
+
+  // Lastly we fix the symbol indexs.
+  uint32_t Index = 0;
----------------
indexs -> indexes


Repository:
  rL LLVM

https://reviews.llvm.org/D41684