[PATCH] D41665: [Docs] Add Contributing page.

Sean Silva via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 3 20:27:40 PST 2018


silvas accepted this revision.
silvas added a comment.
This revision is now accepted and ready to land.

This is awesome, thanks for doing this Florian!

I agree with others that we have various newbie information spread across various pages, but refactoring that is a bigger task and this is a great start (besides being an awesome independent improvement by itself).



================
Comment at: docs/Contributing.rst:64
+To make sure the right people see your patch, please select suitable reviewers
+and add them to your patch when requesting a review. Suitable reviewers are the
+code owner (see CODE_OWNERS.txt) and other people doing work in the area your
----------------
Can you somehow mention that adding a reviewer for an email patch means adding them to the  CC of the email and that for Phab that means to fill in the field in the web UI?


https://reviews.llvm.org/D41665





More information about the llvm-commits mailing list