[PATCH] D41705: Place undefined globals in .bss instead of .data

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 3 13:38:33 PST 2018


efriedma added inline comments.


================
Comment at: lib/Target/TargetLoweringObjectFile.cpp:66
+    for (unsigned i = 0, e = C->getNumOperands(); i != e; ++i) {
+      Constant *E = cast<Constant>(C->getOperand(i));
+      if (!E->isNullValue() && !isa<UndefValue>(E))
----------------
What if E is a ConstantAggregate?


https://reviews.llvm.org/D41705





More information about the llvm-commits mailing list