[PATCH] D41686: Simplify mips gprel handling

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 3 08:22:36 PST 2018


r321733.

Cheers,
Rafael

Simon Atanasyan via Phabricator <reviews at reviews.llvm.org> writes:

> atanasyan accepted this revision.
> atanasyan added a comment.
> This revision is now accepted and ready to land.
>
> LGTM
>
>
>
> ================
> Comment at: ELF/Relocations.cpp:894
> +    //
> +    // To get MIPS relocation type we apply 0xff mask. In case of O32 ABI all
> +    // relocation types occupy eight bit. In case of N64 ABI we extract first
> ----------------
> We can drop this paragraph now,
>
>
> https://reviews.llvm.org/D41686


More information about the llvm-commits mailing list