[PATCH] D41335: [InlineFunction] Inline vararg functions that do not access varargs.

[Florian Hahn via Phabricator via llvm-commits]

fhahn added a comment.

I think the issues raised by @rnk should be addressed in https://reviews.llvm.org/D41555 and https://reviews.llvm.org/D41556 . Those 2 patches are based on this one, and I was planning to commit them straight after committing this one.



================
Comment at: test/Transforms/Inline/inline-varargs.ll:18
+; CHECK-LABEL: define void @thunk_caller(i8* %p)
+; CHECK: call void (i8*, ...) bitcast (void (i8*, i32)* @ext_method to void (i8*, ...)*)(i8* %this_adj.i, i32 42)
+
----------------
fhahn wrote:
> rnk wrote:
> > I was hoping instcombine would simplify this to `call void @ext_method(i8* %this_adj.i, i32 42)`. I hope there's no reason we can't and that instcombine just hasn't been taught how to do it yet, but let's leave a FIXME comment here for it.
> I'll check!
I've opened D41633, which should address the issue.


https://reviews.llvm.org/D41335