[PATCH] D41617: [AMDGPU] Add HW_REG_SH_MEM_BASES symbolic name for s_getreg_b32

[Artem Tamazov via Phabricator via llvm-commits]

artem.tamazov requested changes to this revision.
artem.tamazov added inline comments.
This revision now requires changes to proceed.


================
Comment at: lib/Target/AMDGPU/Utils/AMDGPUAsmUtils.cpp:71
+  nullptr,
+  nullptr,
+  "HW_REG_SH_MEM_BASES"
----------------
nullptr's seem to be unacceptable right away, look at lib\Target\AMDGPU\InstPrinter\AMDGPUInstPrinter.cpp line 1311:

```
  O << "hwreg(";
  if (ID_SYMBOLIC_FIRST_ <= Id && Id < ID_SYMBOLIC_LAST_) {
    O << IdSymbolic[Id];
  } else {
    O << Id;
  }

```
Also please consider lib\Target\AMDGPU\AsmParser\AMDGPUAsmParser.cpp, line 2950.


https://reviews.llvm.org/D41617