[PATCH] D41624: Fix crash when linking metadata with ODR type uniquing

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added inline comments.


================
Comment at: lib/Linker/IRMover.cpp:957
   Constant *C = NewGV;
-  if (DGV)
+  if (DGV && NewGV != SGV)
     C = ConstantExpr::getBitCast(NewGV, TypeMap.get(SGV->getType()));
----------------
Might be worth a comment?


================
Comment at: test/ThinLTO/X86/Inputs/dicompositetype-unique2.ll:56
+!32 = distinct !DILexicalBlock(scope: !8, file: !1, line: 2)
+!33 = !DILocation(line: 2, scope: !8)
----------------
Can all the metadata input be minimized?


https://reviews.llvm.org/D41624