[PATCH] D41606: [COFF] support /ignore:4217

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 28 10:51:46 PST 2017


mstorsjo added a comment.

In https://reviews.llvm.org/D41606#964821, @smeenai wrote:

> General question: it looks like a lot of COFF tests are written using yaml2obj, whereas ELF always uses assembly files and llvm-mc (and I've been following that pattern for the few COFF patches I've written as well). Is there an actual preference for yaml2obj tests in COFF, or is it just a historic artifact? I personally find assembly tests a lot easier to understand.


I also agree that .s tests are easier. I remember some of the tests I've added recently where I despite that ended up using yaml2obj for features that weren't quite as easy to express in .s form.


Repository:
  rL LLVM

https://reviews.llvm.org/D41606





More information about the llvm-commits mailing list