[PATCH] D41592: [ELF] - Add missing dynamic tags when producing output with IRelative relocations only.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 28 02:49:01 PST 2017


>>  // Add remaining entries to complete .dynamic contents.
>>  template <class ELFT> void DynamicSection<ELFT>::finalizeContents() {
>>    if (this->Size)
>> @@ -1081,20 +1095,27 @@
>>          addInt(IsRela ? DT_RELACOUNT : DT_RELCOUNT, NumRelativeRels);
>>      }
>>    }
>> -  if (InX::RelaPlt->getParent() && !InX::RelaPlt->empty()) {
>
>This runs after  removeUnusedSyntheticSections, right? If so I think we
>can just drop InX::RelaPlt->empty() and use addOutSec instead of
>addInSec, no?
>
>Cheers,
>Rafael

You right, it could be one line change..
Even no need to use addOutSec(), will update patch in a minute.

George.


More information about the llvm-commits mailing list