[PATCH] D41426: [WebAssembly] Refactor symbol and symbol table to remove WasmSymbol references

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: wasm/InputFiles.cpp:265
 
-Symbol *ObjFile::createUndefined(const WasmSymbol &Sym,
+Symbol *ObjFile::createUndefined(const WasmSymbol &Sym, Symbol::Kind Kind,
                                  const WasmSignature *Signature) {
----------------
It felt that the function signature is a bit too flexible (for example, you could pass Kind::UndefinedFunctionKind to createDefined function), but since these functions are private functions, that's perhaps okay.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D41426