[PATCH] D41567: Add NO_EXEC_STACK_DIRECTIVE to chkstk and chkstk2 sources

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 26 12:46:17 PST 2017


mstorsjo added a comment.

In https://reviews.llvm.org/D41567#963799, @martell wrote:

> hmm, looking at the #define for NO_EXEC_STACK_DIRECTIVE
>  once the two files have been removed from non windows targets they won't do anything anymore.


Yes, it's not really needed for chkstk for windows. As for what the condition should be, MINGW or "WIN32 and NOT MSVC", I don't have much of an opinion. (The comment I got in the mail said something about that, but this comment seems to have been revised?)


Repository:
  rL LLVM

https://reviews.llvm.org/D41567





More information about the llvm-commits mailing list