[llvm] r321459 - It's a fix for Bug 35741 - can't use comments after x86 prefixes.

Andrew V. Tischenko via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 26 10:29:53 PST 2017


Author: avt77
Date: Tue Dec 26 10:29:52 2017
New Revision: 321459

URL: http://llvm.org/viewvc/llvm-project?rev=321459&view=rev
Log:
It's a fix for Bug 35741 - can't use  comments after x86 prefixes.
Differential Revision: https://reviews.llvm.org/D41579

Modified:
    llvm/trunk/lib/Target/X86/AsmParser/X86AsmParser.cpp
    llvm/trunk/test/MC/X86/x86-64.s

Modified: llvm/trunk/lib/Target/X86/AsmParser/X86AsmParser.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/AsmParser/X86AsmParser.cpp?rev=321459&r1=321458&r2=321459&view=diff
==============================================================================
--- llvm/trunk/lib/Target/X86/AsmParser/X86AsmParser.cpp (original)
+++ llvm/trunk/lib/Target/X86/AsmParser/X86AsmParser.cpp Tue Dec 26 10:29:52 2017
@@ -2377,10 +2377,11 @@ bool X86AsmParser::ParseInstruction(Pars
     Flags |= Prefix;
     Name = Parser.getTok().getString();
     Parser.Lex(); // eat the prefix
-    // Hack: we could have something like
+    // Hack: we could have something like "rep # some comment" or
     //    "lock; cmpxchg16b $1" or "lock\0A\09incl" or "lock/incl"
     while (Name.startswith(";") || Name.startswith("\n") ||
-           Name.startswith("\t") || Name.startswith("/")) {
+           Name.startswith("#") || Name.startswith("\t") ||
+           Name.startswith("/")) {
       Name = Parser.getTok().getString();
       Parser.Lex(); // go to next prefix or instr
     }

Modified: llvm/trunk/test/MC/X86/x86-64.s
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/MC/X86/x86-64.s?rev=321459&r1=321458&r2=321459&view=diff
==============================================================================
--- llvm/trunk/test/MC/X86/x86-64.s (original)
+++ llvm/trunk/test/MC/X86/x86-64.s Tue Dec 26 10:29:52 2017
@@ -99,6 +99,10 @@
 // CHECK: shll $2, %eax
         sall $2, %eax
 
+// CHECK: rep movsb
+rep     # comment
+movsb
+
 // CHECK: rep
 // CHECK: insb
         rep;insb




More information about the llvm-commits mailing list