[PATCH] D41477: [LLD] [ELF] Result of subtracting two symbols should be absolute

[Rafael Avila de Espindola via llvm-commits]

I added a comment in r321458.

I didn't mention bfd, since it is fairly inconsistent about what symbols
are absolute.

Cheers,
Rafael


Rui Ueyama via Phabricator <reviews at reviews.llvm.org> writes:

> ruiu added inline comments.
>
>
> ================
> Comment at: ELF/ScriptParser.cpp:153
>  
>  static ExprValue sub(ExprValue A, ExprValue B) {
> +  if (!A.isAbsolute() && !B.isAbsolute())
> ----------------
> Please add a comment saying that subtracting two symbol values should logically should yield an absolute value and that's actually what the bfd linker produces.
>
>
> Repository:
>   rLLD LLVM Linker
>
> https://reviews.llvm.org/D41477