[PATCH] D41568: [cmake] Always respect existing CMAKE_REQUIRED_FLAGS when adding additional ones.

Saleem Abdulrasool via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Dec 24 15:11:40 PST 2017


compnerd accepted this revision.
compnerd added inline comments.
This revision is now accepted and ready to land.


================
Comment at: cmake/modules/CheckAtomic.cmake:11
   set(OLD_CMAKE_REQUIRED_FLAGS ${CMAKE_REQUIRED_FLAGS})
-  set(CMAKE_REQUIRED_FLAGS "-std=c++11")
+  set(CMAKE_REQUIRED_FLAGS "${CMAKE_REQUIRED_FLAGS} -std=c++11")
   CHECK_CXX_SOURCE_COMPILES("
----------------
I really wish that we could reuse the language properties instead.


https://reviews.llvm.org/D41568





More information about the llvm-commits mailing list