[PATCH] D41551: [ELF] - Allow relocation to a weak undefined symbol when -z notext is given.
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Dec 23 21:34:24 PST 2017
grimar added inline comments.
Comment at: ELF/Relocations.cpp:607
// Or, if we are allowed to create dynamic relocations against
// read-only sections (i.e. when "-z notext" is given),
> I think this comment was previously a logical continuation of the "is simply writable" comment, and the "Or," and ", too." don't quite really follow with the reordering, maybe just "If we are allowed ... a dynamic relocation as we want."
Thanks, Ed !
More information about the llvm-commits