[PATCH] D41206: [llvm-cov] Multi-threaded implementation of prepareFileReports method.

Max Moroz via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 22 15:19:04 PST 2017

Dor1s added a comment.

All comments have been addressed + a test have been added.

Comment at: tools/llvm-cov/CoverageReport.h:53
+                          FileCoverageSummary *FileReport,
+                          const CoverageFilter *Filters);
I don't like having raw pointers here, but I can't get it to work otherwise. The most recent issue I had: Filters were not applied, when I've been using const reference. Once I changed that to a pointer, it started to work. Is there any better pattern of using ThreadPool?


More information about the llvm-commits mailing list