[PATCH] D41206: [llvm-cov] Multi-threaded implementation of prepareFileReports method.

Max Moroz via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 21 15:08:48 PST 2017

Dor1s marked 2 inline comments as done.
Dor1s added inline comments.

Comment at: tools/llvm-cov/CoverageSummaryInfo.h:190
+  FileCoverageSummary &operator+=(const FileCoverageSummary &RHS) {
+    assert((RHS.Name.empty() || RHS.Name == LHS.Name) &&
+           "Addition of file coverage summary from different files.");
vsk wrote:
> Dor1s wrote:
> > vsk wrote:
> > > If we stipulate that file summaries have valid names, we could avoid a bit of this complexity.
> > Sure!  But we still need to verify that `RHS.Name == LHS.Name`, right?
> Right, that can't hurt.
Wait, I'm stupid... Removing this assert right now.


More information about the llvm-commits mailing list