[PATCH] D41474: Fix a crash in lazy loading of Metadata in ThinLTO

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 21 09:09:48 PST 2017

tejohnson added inline comments.

Comment at: lib/Bitcode/Reader/BitcodeReader.cpp:4620
+  if (MDLoader->hasFwdRefs())
+    MDLoader->finishFunctionMetadata();
I think this is just hiding the issue that the below error is trying to catch. That is - we created a forward ref and didn't resolve it as expected during the function parsing.

What created the forward ref? Do you know why it wasn't resolved in the usual way?

The description of r291027 lists some limitations - is there another one that needs to be handled specially  (e.g. like the METADATA_GLOBAL_DECL_ATTACHMENT case)?


More information about the llvm-commits mailing list