[PATCH] D36045: Extend syntax of response files

Hal Finkel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 21 08:58:06 PST 2017

hfinkel added a comment.

In https://reviews.llvm.org/D36045#962166, @sepavloff wrote:

> Is there any opinion about feasibility of this extension?
>  This patch is a prerequisite for https://reviews.llvm.org/D24933 (Enable configuration files in clang), which is now accepted.
>  If it is not acceptable for all response files, then it must be implemented for config files only.

I like the extension, but making our parsing of response files differ from GCC's in this regard might not be an improvements (e.g., the handling of the escaped new lines, and even the comments, could be a breaking change). Can you add a new parameter (e.g., bool ExtendedSyntax = false), and then predicate the new behavior on that? Then set that parameter to true when parsing config files from Clang?


More information about the llvm-commits mailing list