[PATCH] D41490: [YAML] Fix UTF-8 handling

Jonas Devlieghere via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 21 08:52:29 PST 2017

JDevlieghere added inline comments.

Comment at: unittests/Support/YAMLIOTest.cpp:2546
+TEST(YAMLIO, TestEscapedUTF8SingleQuoteInsideDoubleQuote) {
+  std::string Id = "parameter ''параметр'' is unused";
I'd remove the double single quotes here though, it doesn't really add anything to the test case except confusion. 

Comment at: unittests/Support/YAMLIOTest.cpp:2559
+TEST(YAMLIO, TestEscapedUTF8) {
+  std::string Id = "/*параметр*/";
Maybe merge this with the previous test case?


More information about the llvm-commits mailing list