[PATCH] D41360: [AARCH64] Enable fp16 data type for the Builtin in aarch64 only

Abderrazek Zaafrani via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 21 08:20:56 PST 2017


az added a comment.

In https://reviews.llvm.org/D41360#961869, @SjoerdMeijer wrote:

> Looks reasonable to me.
>
> Just checking, do we need those changes in CodeGen/arm_neon_intrinsics.c? I mean, trunk is already using i16 in these tests.


It depends on how I check in the old reverted code (the one in https://reviews.llvm.org/D32511) with this one.  If I put back the reverted code as is first and then check in this one separately, then we need  the changes in arm_neon_intrinsics.c. If we combine this one with the old one into one checkin, then it is not needed. I will probably go with the former so that when support for fp16 in arm32 in complete, we can revert the whole code here but I am open to suggestions.


https://reviews.llvm.org/D41360





More information about the llvm-commits mailing list