[PATCH] D41453: [GVNHoist] Fix: PR35222 gvn-hoist incorrectly erases load in case of a loop

Sebastian Pop via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 21 07:55:12 PST 2017

sebpop accepted this revision.
sebpop added a comment.
This revision is now accepted and ready to land.

This change looks good.

For the other uses of dominates, you could add an assert(dominates == properlyDominates) that would allow you to automate the extraction of testcases with bugpoint when that is not the case.
We would then have to reason on a case by case whether dominates should be changed.


More information about the llvm-commits mailing list