[PATCH] D41449: [WebAssembly] Add extra test for weak global symbols

Nicholas Wilson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 21 02:56:03 PST 2017

ncw added a comment.

Since the relocation is emitted in the function body, which is tested, it should be good enough for now.

https://reviews.llvm.org/D41390 modifies this test (by discarding the duplicate InputSegment), at which point the test is even more precise. Until https://reviews.llvm.org/D41390 lands, this test doesn't need to be too precise since it's currently asserting "wrong" output (both copies of the weak functions and weak globals are there in the CODE/DATA sections).

I'd say it's fine to commit this as-is - we're revisiting it soon.

  rLLD LLVM Linker


More information about the llvm-commits mailing list