[PATCH] D41290: [YAML] Add support for non-printable characters

Vladimir Plyashkun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 21 00:30:44 PST 2017

vladimir.plyashkun added a comment.

Hello @thegameg !
Is is correct that printable UTF-8 characters are also escaped by these changes?
For example, Clang-Tidy output  now uses double-quotes for UTF-8:

  Message:         "parameter '\xffffffffffffffd0\xffffffffffffffbf\xffffffffffffffd0\xffffffffffffffb0\xffffffffffffffd1\xffffffffffffff80\xffffffffffffffd0\xffffffffffffffb0\xffffffffffffffd0\xffffffffffffffbc\xffffffffffffffd0\xffffffffffffffb5\xffffffffffffffd1\xffffffffffffff82\xffffffffffffffd1\xffffffffffffff80' is unused"

but previously it was simply:

  Message:         'parameter ''параметр'' is unused'

I'm using snakeyaml <https://bitbucket.org/asomov/snakeyaml> which is cannot recognize these sequences. By this i've got incorrect clang-tidy output.
Also i saw that not all the UTF-8 characters are printed in double quotes.
For example in the same output,

  ReplacementText: ' /*параметр*/'

printed in the single quotes.



More information about the llvm-commits mailing list