[PATCH] D41362: [AArch64][GlobalISel] Enable GlobalISel at -O0 by default

Quentin Colombet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 20 23:45:31 PST 2017


qcolombet added a comment.

> How about checking for EnableGlobalISelAbort.getNumOccurences() > 0 to check for an command line override, otherwise doing what the target wants via the isGlobalISelAbortEnabled() override?

That's what I meant :). (Instead of adding a `== 3` case for the option.)

Now, regarding the `we should double check` thing, I meant that we should double check that the `-aarch64-enable-global-isel-at-O=0` properly set abort to false in the aarch64 override.


Repository:
  rL LLVM

https://reviews.llvm.org/D41362





More information about the llvm-commits mailing list