[PATCH] D41146: [DWARF] DWARF v5: Rework of string offsets table reader

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 20 15:34:42 PST 2017

aprantl added a comment.

thanks! I'll defer to Jonas to accept this.

Comment at: lib/DebugInfo/DWARF/DWARFContext.cpp:113
+              if (!L)
+                return true; // Invalid L should always precede R.
+              if (R)
Not sure if this matters, but won't this be nondeterministic when both L and R are invalid?

Comment at: lib/DebugInfo/DWARF/DWARFContext.cpp:128
+                      return L->Base == R->Base && L->Size == R->Size;
+                    return false;
+                  }),
see above


More information about the llvm-commits mailing list