[PATCH] D41342: [InstCombine] Missed optimization in math expression: simplify calls exp functions

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 20 13:13:57 PST 2017

spatel added a comment.

In https://reviews.llvm.org/D41342#960505, @Quolyk wrote:

> Since I'm new to llvm, I looked though other test files, and noticed that it isn't necessary to write full test-check, instead people write just one instruction to make sure test is ok, while consequent instructions doesn't matter. I wonder what style is preferred?

Checks used to be mostly written by hand (and had a lot of shortcomings and bugs because of that). Now that we have scripts to auto-generate checks, I prefer that you use those scripts when possible. It should make subsequent changes or additions to the test file easier for other contributors.


More information about the llvm-commits mailing list