[PATCH] D41338: [CodeGen] lower math intrinsics to finite version of libcalls when possible (PR35672)

Hal Finkel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 20 13:01:15 PST 2017


hfinkel added a comment.

In https://reviews.llvm.org/D41338#961372, @efriedma wrote:

> > and calls to <foo>l/__<foo>l_finite for f128 everywhere else. No?
>
> There are four ways to lower C long double to LLVM IR: fp128, ppc_f128, x86_fp80, and double.  If you assume the IR doesn't contain any intrinsic calls which can't be lowered, the logic becomes simpler, but I'm not sure that's a safe assumption.


Historically, I believe that we've made this assumption. That's, in part, why all of the intrinsics say "Not all targets support all types however." in the LangRef.


https://reviews.llvm.org/D41338





More information about the llvm-commits mailing list