[PATCH] D41373: [GISel][RFC]: GlobalISel Combiner prototype

Hal Finkel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 20 11:12:08 PST 2017

hfinkel added inline comments.

Comment at: include/llvm/CodeGen/GlobalISel/GMIPatternMatch.h:163
+    MachineInstr *TmpMI;
+    if (gi_match(Op, MRI, m_MInstr(TmpMI))) {
+      if (TmpMI->getOpcode() == Opcode && TmpMI->getNumOperands() == 3) {
aditya_nandakumar wrote:
> hfinkel wrote:
> > Why is this named gi_match? Doesn't it apply to any MI as well?
> Hi Hal,
> The match function above has been named gi_match as I was not sure if there is interest in using this beyond GlobalISel. We can definitely have it named match (and perhaps remove the GI prefix from all the matchers as well).
I think it would be great to be able to use these on SSA MI as well (but then having the 'gi' prefix will look odd).


More information about the llvm-commits mailing list