[PATCH] D41300: [ARM] Fix PR35379 - incorrect unwind information when compiling with -Oz

Momchil Velikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 20 10:12:56 PST 2017


chill marked 2 inline comments as done.
chill added inline comments.


================
Comment at: lib/Target/ARM/ARMAsmPrinter.cpp:1120
+        // corresponding stack slots.
+        if (MO.isUndef()) {
+          Pad += 4;
----------------
rprichard wrote:
> I wonder if we should assert that the registers to skip appear at the front of the instruction. e.g. Add an `assert(RegList.empty());` inside the `MO.isUndef()` block.
To me, it makes sense doing it.


https://reviews.llvm.org/D41300





More information about the llvm-commits mailing list