[PATCH] D41358: [PowerPC] Fix minor bug to avoid a failure in createTailCallBranchInstr

Hal Finkel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 20 09:16:01 PST 2017


hfinkel added a comment.

In https://reviews.llvm.org/D41358#961092, @stefanp wrote:

> @hfinkel 
>  Hi Hal, 
>  Thank you for the approval. After doing a bit more investigation I realized that the condition should always be true. Before calling this function we always check that this is a return block. Therefore, I've change it slightly so that the guard is now an assert.


Sounds good; please proceed. The rest of the code clearly assumes that the iterator is valid.


https://reviews.llvm.org/D41358





More information about the llvm-commits mailing list