[PATCH] D41335: [InlineFunction] Inline vararg functions that do not access varargs.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 20 08:21:27 PST 2017


fhahn updated this revision to Diff 127734.
fhahn added a comment.
Herald added a subscriber: haicheng.

Moved legality check to InlineCost.cpp

It seems to fit nicely into InlineCost.cpp. The only problem is that for example the PartialInliner uses `InlineFunction()` without using `InlineCost`, so it misses all the legality checks from there. But there are already plenty of cases where `InlineCost` checks for legality, so this should be addressed in the PartialInliner IMO.


https://reviews.llvm.org/D41335

Files:
  lib/Analysis/InlineCost.cpp
  lib/Transforms/Utils/InlineFunction.cpp
  test/Transforms/Inline/inline-musttail-varargs.ll
  test/Transforms/Inline/inline-varargs.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D41335.127734.patch
Type: text/x-patch
Size: 7371 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171220/ca28e480/attachment.bin>


More information about the llvm-commits mailing list