[PATCH] D40782: [tablegen] Make strconcat return code if all arguments are code

Johannes Altmanninger via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 20 07:31:41 PST 2017

johannes added a comment.

In https://reviews.llvm.org/D40782#960474, @hfinkel wrote:

> In https://reviews.llvm.org/D40782#958027, @johannes wrote:
> > I use a different approach now, WDYT?
> I'm not sure I like this. Before it was clear: !strconcat is for strings, !codeconcat was for code. Having !strconcat also work on code, and return something which isn't a string, seems unfortunate. And we also have !listconcat. If we want to unify things, I think it would make sense to add !concat (which works on all of those things). [If you do this, then also support !strconcat and !listconcat as aliases to be nice to out-of-tree backends].

Oh right, thanks, implementing !concat plus the aliases for the old functions seems to be the cleanest solution, assuming that this change won't cause too much confusion in existing code. I think it should be fine but I don't know how many people are using these operators.


More information about the llvm-commits mailing list