[PATCH] D41430: [ARM] Armv8-R DFB instruction

[Sam Parker via Phabricator via llvm-commits]

samparker added inline comments.


================
Comment at: lib/Target/ARM/ARM.td:89
+
+
 def FeatureAcquireRelease : SubtargetFeature<"acquire-release",
----------------
fhahn wrote:
> I would just use a single new line here.
cheers.


================
Comment at: lib/Target/ARM/ARMInstrInfo.td:4813
+                "dfb", "", []>,
+                Requires<[IsARM, HasDFB]> , Sched<[WriteALU]> {
+                let Inst{31-0} = 0xf57ff04c;
----------------
fhahn wrote:
> Are you sure about `Sched<[WriteALU]>`? It's an alias to the `DSB` instruction , which does not have a similar `Sched`
I'm not, but couldn't find where/how DSB got its scheduling info. Do you know where its defined? I should probably also add an InstAlias to DSB...


https://reviews.llvm.org/D41430