[PATCH] D40782: [tablegen] Make strconcat return code if all arguments are code

Hal Finkel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 19 21:36:31 PST 2017

hfinkel added a comment.

In https://reviews.llvm.org/D40782#958027, @johannes wrote:

> I use a different approach now, WDYT?

I'm not sure I like this. Before it was clear: !strconcat is for strings, !codeconcat was for code. Having !strconcat also work on code, and return something which isn't a string, seems unfortunate. And we also have !listconcat. If we want to unify things, I think it would make sense to add !concat (which works on all of those things). [If you do this, then also support !strconcat and !listconcat as aliases to be nice to out-of-tree backends].


More information about the llvm-commits mailing list