[PATCH] D41361: [SimplifyCFG] Avoid quadratic on a predecessors number behavior in instruction sinking.

Michael Zolotukhin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 19 19:10:57 PST 2017


mzolotukhin added a comment.



In https://reviews.llvm.org/D41361#960373, @efriedma wrote:

> > test/CodeGen/AArch64/arm64-jumptable.ll - changes in this test mimic the changes that previous implementation of SimplifyCFG would do.
>
> With your patch, what transform do we perform here instead of sinking?  As far as I can tell, SimplifyCFG doesn't make any other changes.


I don't think SimplifyCFG makes any other changes, but the test isn't for SimplifyCFG - as far as I understand it, it's for instructions we generate in the backend. The test was just written to trigger some specific situation, and with this change it stopped triggering it.

Michael


https://reviews.llvm.org/D41361





More information about the llvm-commits mailing list