[PATCH] D41226: LiveDebugValues spill recognition expasnsion

[Wolfgang Pieb via Phabricator via llvm-commits]

wolfgangp added inline comments.


================
Comment at: lib/CodeGen/LiveDebugValues.cpp:452
+          }
+      }
     }
----------------
If I read the code correctly, it would identify *any* instruction that stores a register to the stack as a spill instruction. The lambda sets "Reg" in line 439 unconditionally and the following code just checks whether "Reg" is used and killed, but doesn't set it back to 0 if it is not, so line 455 would always return true.

Was this the intent? If so, we wouldn't need to look at the next instruction at all. 

I wrote the code originally to be very conservative in the identification of a spill, perhaps too conservative.


================
Comment at: test/DebugInfo/X86/kill-after-spill.mir:5
+# in istruction after the spill occurs
+
+--- |
----------------
Typo: instruction

Also, please end the sentence with a full stop! 


https://reviews.llvm.org/D41226