[PATCH] D41131: [AArch64] Implement stack probing for windows

Saleem Abdulrasool via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 19 14:14:33 PST 2017

compnerd accepted this revision.
compnerd added a comment.
This revision is now accepted and ready to land.

Please do add the docs that the large code model behavior is an extension.

Comment at: lib/Target/AArch64/AArch64FrameLowering.cpp:367
   // callee-save save/restores
-  if (StackBumpBytes >= 512)
+  if (StackBumpBytes >= 512 || windowsRequiresStackProbe(MF, StackBumpBytes))
     return false;
Why not just combine these into a single `requiresStackProbe`?

Comment at: lib/Target/AArch64/AArch64FrameLowering.cpp:498
   int NumBytes = (int)MFI.getStackSize();
-  if (!AFI->hasStackFrame()) {
+  if (!AFI->hasStackFrame() && !windowsRequiresStackProbe(MF, NumBytes)) {
     assert(!HasFP && "unexpected function without stack frame but with FP");


More information about the llvm-commits mailing list