[PATCH] D41382: [AArch64] Asm: Fix parsing of register aliases that have a name starting with 'z'

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 19 13:53:18 PST 2017


fhahn added reviewers: echristo, olista01.
fhahn added a comment.

LGTM. The problem this solves is that `MatchRegisterName` parses GPRs, NEON and SVE registers, which leads to surprising behaviour, i.e. `matchRegisterNameAlias` with RegKind == Scalar would return > 0 for any (valid) Neon & SVE register as well. From the comments and the behaviour, it seems like `tryParseRegister` should only parse scalar registers, which this patch implements. I think it's worth adding a comment making that clear.

Adding Eric, in case he has some more thoughts!


https://reviews.llvm.org/D41382





More information about the llvm-commits mailing list