[PATCH] D40973: [LV] Remove unnecessary DoExtraAnalysis guard (silent bug)

Diego Caballero via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 19 12:52:28 PST 2017

dcaballe added a comment.

Thanks for the test, Florian.

Maybe I'm missing something but the bug/fix don't affect the early exit flag value (DoExtraAnalysis) so the early exit behavior won't change before/after the fix.
Instead of matching debug info that is not related to the pre-header check (and may lead to unrelated failures in the future), I thought that we could add a new debug message for the pre-header check.
It seems a more reliable way to test it.

What do you think? Is my latest diff reasonable?



More information about the llvm-commits mailing list