[PATCH] D41402: [cmake] Fix DESTDIR support in compiler-rt build

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai requested changes to this revision.
smeenai added a comment.
This revision now requires changes to proceed.

cmake will expand out relative paths for `PATH` cache variables, so the `.` will actually be expanded out to the build directory, which isn't desirable. You need to use the `STRING` type to avoid this normalization (though that's hacky).

Also, the canonical path is actually `$ENV{DESTDIR}${CMAKE_INSTALL_PREFIX}`; i.e., `DESTDIR` is supposed to contain the trailing slash itself.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D41402