[PATCH] D28907: [SLP] Fix for PR30787: Failure to beneficially vectorize 'copyable' elements in integer binary ops.

Dinar Temirbulatov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 18 20:36:34 PST 2017

dtemirbulatov added inline comments.

Comment at: lib/Transforms/Vectorize/SLPVectorizer.cpp:3244
         isJumbled = true;
-        LI = cast<LoadInst>(E->Scalars[0]);
-      } else {
-        LI = cast<LoadInst>(VL0);
-      }
+      LI = cast<LoadInst>(E->Scalars[0]);
ABataev wrote:
> dtemirbulatov wrote:
> > We used E->VL0 here before, which is not correct because it could point to a wrong element.
> Why could it point to a wrong element? As I understand, it should always point to Scalars[0] for LoadInst.
No, it is in order as it was discovered. I will add a testcase for the issue.


More information about the llvm-commits mailing list